Zulip Chat Archive
Stream: PR reviews
Topic: !4#4169 LinearAlgebra.Matrix.Charpoly.Coeff
Damiano Testa (May 21 2023 at 17:01):
While preparing !4#4169 for porting, the unused variable linter pointed out that a have
was unneeded. This was already the case in the original mathlib3 file.
Here are the two links to the relevant, unused, have
s:
- in the original mathlib3,
- in the ported mathlib4.
Should I remove the have
from both?
Ruben Van de Velde (May 21 2023 at 17:05):
I'd definitely remove it in mathlib 4, but it's probably not worth backporting
Damiano Testa (May 21 2023 at 17:08):
Ok, I left a porting note and I commented out the have
: should I simply leave the porting note and remove the commented have
?
Eric Wieser (May 21 2023 at 17:56):
Yeah, generally backporting proof lintfixes isn't worth it. Backporting statement fixes probably is, if that ever happens.
Scott Morrison (May 22 2023 at 01:33):
I wouldn't even leave a porting note for this, tbh.
Last updated: Dec 20 2023 at 11:08 UTC