Zulip Chat Archive

Stream: PR reviews

Topic: 3395: QPF


view this post on Zulip Yury G. Kudryashov (Jul 19 2020 at 14:40):

I see that nobody reviews #3395. I hope that this is not because I left a few comments and now people think that I'm going to review it. This PR is far away from analysis, and my comments were about docstrings. In particular, after my comments @Simon Hudon rewrote the module docstring to make it clear for people like me that this is not for us.

view this post on Zulip Scott Morrison (Jul 19 2020 at 14:41):

Can @Mario Carneiro and/or @Jeremy Avigad review it? I don't think we're particularly worried about CoI. :-)

view this post on Zulip Rob Lewis (Jul 19 2020 at 14:49):

@Gabriel Ebner was working on this series but he's on vacation for the next week.

view this post on Zulip Jeremy Avigad (Jul 19 2020 at 23:36):

I'll review it tomorrow.


Last updated: May 07 2021 at 19:12 UTC