Zulip Chat Archive

Stream: PR reviews

Topic: Dualizing category theory API


Dagur Asgeirsson (Jul 04 2024 at 13:56):

I've reviewed #14258 and #14171, which are both straightforward dualizations of existing API in the category theory library, and should be ready to merge

Dagur Asgeirsson (Jul 05 2024 at 12:09):

The next one in the Kan extension refactor is ready to go: #14261

(I hope it's ok to use this channel to notify maintainers about PRs that I've reviewed and think are ready to merge, I just don't want them to go unnoticed for long after the review)

Johan Commelin (Jul 05 2024 at 13:49):

Thanks a lot for the review! And yes, posting comments like this is very welcome and encouraged!

Ruben Van de Velde (Jul 05 2024 at 17:21):

There's only one risk, and that's that at one point you might be roped into becoming a reviewer :)

Dagur Asgeirsson (Jul 05 2024 at 18:40):

Nothing wrong with that :smiley:

Dagur Asgeirsson (Jul 10 2024 at 09:58):

#14236 should be ready to go


Last updated: May 02 2025 at 03:31 UTC