Zulip Chat Archive
Stream: PR reviews
Topic: Integral curves on manifolds
Winston Yin (尹維晨) (Nov 28 2023 at 09:18):
Freshly baked and ready for review:
- #8483 proves the local existence of integral curves for tangent vector fields on manifolds
- #8624 defines the interior and boundary points of a manifold (by @Michael Rothgang)
- #8672 defines
tangentCoordChange
, an abbreviation ofVectorBundleCore.coordChange
fortangentBundleCore
The first PR depends on the latter two.
Michael Rothgang (Nov 29 2023 at 15:13):
I've looked at both PRs (which are not mine) and think they're basically ready to go. I don't have review rights - somebody else also needs to approve :-)
Scott Morrison (Nov 29 2023 at 22:14):
@Michael Rothgang, while someone else has to do the maintainer merge
or bors merge
command, you can see leave an "approve" review, which will display your name with a green check mark saying that you have approved. This information is very helpful to the "official" reviewers.
Michael Rothgang (Nov 29 2023 at 22:18):
I know :-)
Let me clarify: I have approved #8672 already (the other PR is still waiting on its dependents).
Winston Yin (尹維晨) (Dec 17 2023 at 05:21):
A series of PRs about integral curves that I've polished to the extent I can (nested to indicate dependency):
- #9013 uniform time lemma for the existence of global integral curves
Any comments, detailed reviews, and golf attempts welcome!
Winston Yin (尹維晨) (Dec 17 2023 at 05:31):
Also if there are suggestions for how to split these PRs into smaller ones that can be reviewed sooner...
Scott Morrison (Dec 17 2023 at 06:21):
Not sure why bors hasn't either tried again or reported failure on #9066. I would suggest just merge master, and say bors merge
again.
Last updated: Dec 20 2023 at 11:08 UTC