Zulip Chat Archive

Stream: PR reviews

Topic: Open PR on group theory

Antoine Chambert-Loir (Jan 28 2025 at 18:16):

I just opened 3 PR on finite groups and permutation groups:

  • #21186 : subgroups of index 2 are normal, subgroups of index the smallest prime factor are normal
  • #21188 : the alternating group is a characteristic subgroup
  • #21190 : the alternating group is the only subgroup of the permutation group of index 2

They are relatively elementary.

Allow me to recall the more difficult PR which have been open for a long time

  • #17522 : computes the centralizer of a permutation, in particular its cardinality and the cardinality of conjugacy classes
  • #19456 : analogue in the alternating group
  • #12052 : primitive actions
  • #12053 : some theorems for primitive actions on finite sets
  • #12048 : the Iwasawa criterion for simplicity.

Kim Morrison (Jan 28 2025 at 23:45):

@Antoine Chambert-Loir, I see #17522 has many unresolved conversations. Could you mark them all as resolved if that is the case?

Kim Morrison (Jan 28 2025 at 23:46):

Also, I can't find the downstream import report on that PR (and so can't evaluate the large-import label). Perhaps it needs a merge of master?

Antoine Chambert-Loir (Jan 29 2025 at 18:00):

I just closed the two (is that “many”?) conversations that had remained open (as a matter of fact, I had waited for an answer by Johan, but OK), and just merged master.

Kim Morrison (Jan 29 2025 at 22:46):

Thanks. The import increase looks reasonably to me.

Yaël Dillies (Jan 30 2025 at 07:03):

It looks like from all the PRs you mentioned, only #21186 can currently be reviewed. #12052, #17522 and #19456 are waiting on you to fix them, and the other ones are blocked by other PRs

Damiano Testa (Jan 30 2025 at 13:20):

For the sake of the emoji reactions, I will post the PRs that are currently open from the above list, one per message.

Damiano Testa (Jan 30 2025 at 13:21):

  • #21186 : subgroups of index 2 are normal, subgroups of index the smallest prime factor are normal

Damiano Testa (Jan 30 2025 at 13:21):

  • #21190 : the alternating group is the only subgroup of the permutation group of index 2

Damiano Testa (Jan 30 2025 at 13:21):

  • #17522 : computes the centralizer of a permutation, in particular its cardinality and the cardinality of conjugacy classes

Damiano Testa (Jan 30 2025 at 13:21):

  • #19456 : analogue in the alternating group

Damiano Testa (Jan 30 2025 at 13:21):

Damiano Testa (Jan 30 2025 at 13:22):

  • #12053 : some theorems for primitive actions on finite sets

Damiano Testa (Jan 30 2025 at 13:22):

  • #12048 : the Iwasawa criterion for simplicity.

Last updated: May 02 2025 at 03:31 UTC