bors crashed on #11322 and closed the PR

Stream: PR reviews

[Riccardo Brasca]

When creating #11322 I made a mistake and somehow the github system thought I want to merge the branch to another branch of mine instead of master. This made bors crashing and closing the branch. I am reporting this here just in case.

I now opened #11745 that is the exact copy of ##11322. @Oliver Nash would you mind delegating it again (I prefer to avoid opening and merging it myself). Thanks!

[Yaël Dillies]

Bors didn't crash at all. Closing all PRs that want to merge into a deleted branch is expected behavior.

[Yaël Dillies]

You know you can reopen a PR that bors closed, right?

[Riccardo Brasca]

    28/3/2024, 12:36:25     Crash   batch

{%ArgumentError{
   message: "unknown registry: BorsNG.PubSub. Either the registry name is invalid or the registry is not running, possibly because its application isn't started"
 },
 [
   {Registry, :meta, 2,
    [file: 'lib/registry.ex', line: 1068]},
   {Phoenix.PubSub, :broadcast, 4,
    [file: 'lib/phoenix/pubsub.ex', line: 148]},
   {Phoenix.PubSub, :broadcast!, 4,
    [file: 'lib/phoenix/pubsub.ex', line: 241]},
   {BorsNG.Worker.Batcher, :start_waiting_batch, 1,
    [file: 'lib/worker/batcher.ex', line: 462]},
   {BorsNG.Worker.Batcher, :poll_, 1,
    [file: 'lib/worker/batcher.ex', line: 297]},
   {BorsNG.Worker.Batcher, :handle_cast, 2,
    [file: 'lib/worker/batcher.ex', line: 92]},
   {:gen_server, :try_dispatch, 4,
    [file: 'gen_server.erl', line: 1123]},
   {:gen_server, :handle_msg, 6,
    [file: 'gen_server.erl', line: 1200]}
 ]}

[Riccardo Brasca]

this looks to me like a crash. and the "reopen PR" is grey, this is why I opened another one (but I didn't try hard)

[Junyan Xu]

Need to first restore RB/cycl_ex in #10710, then "reopen PR" becomes clickable. (Now reopened)

[Riccardo Brasca]

Ah I see. I closed it again since now there are conflicts and #11745 is how the other one looked like this morning (I mean, the diff).