Stream: PR reviews

Topic: how you do reviews?

Kevin Lacker (Oct 05 2020 at 22:37):

So when y'all do code reviews, are you stepping through it in vscode/emacs? or is everyone suggesting a simplification just like, i'm sure this'll work

Bryan Gin-ge Chen (Oct 05 2020 at 22:45):

Speaking only for myself, a little of both. leanproject makes it very easy to get everything I need to open up a file in VS Code.

Eric Wieser (Oct 05 2020 at 23:00):

It might be possible to set up the new GitHub code spaces too, to run vs-code on a branch in browser

Scott Morrison (Oct 05 2020 at 23:23):

Ooh, that looks shiny. I signed up for the beta.

Last updated: May 07 2021 at 19:12 UTC