Zulip Chat Archive
Stream: PR reviews
Topic: review request: #12120 (new theorems about Real.rpow)
Casavaca (Apr 15 2024 at 01:05):
Could someone review #12120?
Jireh Loreaux (Apr 15 2024 at 03:26):
Reviewed. Here's an easy way to find the first two lemmas I mentioned:
@loogle Finset.sum, Finset.prod, HPow.hPow, Real
loogle (Apr 15 2024 at 03:26):
:search: Real.rpow_sum_of_pos, Real.rpow_sum_of_nonneg, and 9 more
Jireh Loreaux (Apr 15 2024 at 03:28):
And docs#Real.finset_prod_rpow is the fifth hit in:
@loogle Finset.prod, HPow.hPow, Real
loogle (Apr 15 2024 at 03:28):
:search: Real.rpow_sum_of_pos, Real.rpow_sum_of_nonneg, and 32 more
Jireh Loreaux (Apr 15 2024 at 03:29):
and checking the results of the following shows that we don't have the second lemma included in your PR:
@loogle Finset.prod, HPow.hPow, Real, HDiv.hDiv
loogle (Apr 15 2024 at 03:29):
:search: Real.geom_mean_le_arith_mean, integral_sin_pow_even, and 4 more
Casavaca (Apr 15 2024 at 06:06):
@Jireh Loreaux You are right. I'll close this PR. I need to become better on my searching skills.
Jireh Loreaux (Apr 15 2024 at 06:07):
@Casavaca The div version is reasonable to have.
Casavaca (Apr 15 2024 at 07:07):
Cool, I'll open another PR.
Jireh Loreaux (Apr 15 2024 at 12:47):
For future reference, you didn't need to close that one and create a new one. You could instead just update the old one. Note: even if you already closed it, you can just reopen the PR.
Casavaca (Apr 16 2024 at 03:02):
Got it. Let me make some modifications. I'll reopen it.
Last updated: May 02 2025 at 03:31 UTC