Zulip Chat Archive

Stream: Is there code for X?

Topic: comment in Data/Set/Lattice


Edison Xie (Apr 27 2025 at 16:21):

in line 346 there is a comment saying -- classical, is that there on purpose or should that be deleted?

Ruben Van de Velde (Apr 27 2025 at 16:51):

It dates back to the first (technically second) commit of mathlib 3, but I don't see what it could mean, so it'd be fine to delete

Andrew Yang (Apr 27 2025 at 16:59):

It probably means “this lemma uses classical axioms”?

Ruben Van de Velde (Apr 27 2025 at 17:14):

I doubt it's the first in that file. Also line 308 and 312 should go

Ruben Van de Velde (Apr 27 2025 at 17:14):

(I can also pick it up in my next cleanup pr)

Robin Carlier (Apr 27 2025 at 17:24):

There is also a bunch of them starting from line 909. Also in Data/Set/Pairwise/Basic (lines 286, 311, 333). No other occurrences of -- classical within Mathlib.

Yury G. Kudryashov (Apr 27 2025 at 17:27):

I agree with @Andrew Yang above. I think that all these lines can be safely removed from the library.


Last updated: May 02 2025 at 03:31 UTC