Zulip Chat Archive

Stream: Is there code for X?

Topic: non-unital subrings


Adam Topaz (Jun 21 2022 at 15:39):

We have docs#non_unital_ring but do we have sub_nonunital_ring (or non_unitsl_subring). For example, an ideal can be considered as a nonunital subring.

Jireh Loreaux (Jul 08 2022 at 06:26):

@Adam Topaz Sorry I missed this before. I have a draft PR where I have a decent start on this, but I've been busy the past two months.

Jireh Loreaux (Jul 08 2022 at 21:02):

#13749

Adam Topaz (Jul 08 2022 at 23:46):

Ping @Jack McKoen
For your PR involving the maximal ideal of a valuation ring, one could add some API using such nonunital subrings!

Jack McKoen (Jul 09 2022 at 04:10):

Good to know @Adam Topaz , I'll start thinking about this :+1:

Jireh Loreaux (Jul 21 2022 at 17:51):

Note: #13749 is ready modulo CI


Last updated: Dec 20 2023 at 11:08 UTC