Zulip Chat Archive

Stream: Zulip meta

Topic: PR reviews

Wrenna Robson (Jul 05 2022 at 08:20):

Is it considered good practice to post about every PR we have to review in #PR reviews?

Eric Wieser (Jul 05 2022 at 08:26):

I think usually posts there are either for PRs that either:

  • Generated extended discussion and need wider input
  • Have seemingly been forgotten about
  • Are on a particularly notable topic that people might be interested in knowing has been worked on

Wrenna Robson (Jul 05 2022 at 08:33):

Thanks. I'm trying to avoid having too many PRs "in flight" at once but they are slowly growing, so I wanted to understand better how to manage that workflor.

Wrenna Robson (Jul 05 2022 at 08:34):

(Thank you for the review on the couple I just sent in...)

Wrenna Robson (Jul 05 2022 at 08:37):

I've been updating all my extant ones this morning in the hope that I can get some resolved.

Last updated: Dec 20 2023 at 11:08 UTC