Zulip Chat Archive

Stream: triage

Topic: PR !4#11195: chore: showcase deprecation tool


Random Issue Bot (May 13 2024 at 14:08):

Today I chose PR 11195 for discussion!

chore: showcase deprecation tool
Created by @damiano (@adomani) on 2024-03-06
Labels: merge-conflict

Is this PR still relevant? Any recent updates? Anyone making progress?

Damiano Testa (May 13 2024 at 14:19):

This PR did two things:

  • made the date part of the deprecation syntax (now implemented as deprecated since);
  • auto-deprecated all autogenerated declarations.

I suspect that there is not much need for the automation on auto-deprecation: I'll close this PR the next time that the bot will remind me about it! :smile:

Johan Commelin (May 13 2024 at 14:26):

Actually, I think auto-deprecating autogenerated decls will be useful!

At least, if I understand correctly what that means... do you mean auto-generated decls coming from to_additive and/or simps?

Damiano Testa (May 13 2024 at 14:33):

Yes, this is what it means: the command reads the environment before and after the declaration, deprecating all "human-like" statements (i.e. the ones that are not blacklisted).

Damiano Testa (May 13 2024 at 14:34):

I was really sold on this, but then I realised that simpto_additive already has its own "deprecation" syntax. So, except simps, there are not that many other use-cases, I think.

Johan Commelin (May 13 2024 at 14:34):

I still think that is helpful. But would like to hear from others as well, before asking if you want to update the PR.

Johan Commelin (May 13 2024 at 14:34):

simps and to_additive, I guess?

Damiano Testa (May 13 2024 at 14:34):

I am available to update the PR, but I would also like to hear more opinions!


Last updated: May 02 2025 at 03:31 UTC