Zulip Chat Archive

Stream: condensed mathematics

Topic: master broken


Kevin Buzzard (May 06 2022 at 13:15):

I've been pushing to master today and I've just noticed that for_mathlib/homotopy_category_pretriangulated is broken for me. Hopefully this wasn't my fault!

Johan Commelin (May 06 2022 at 13:18):

I'm doing a build. Let's find out what's wrong (-;

Johan Commelin (May 06 2022 at 13:35):

I think I've fixed it. One more check, then I'll push

Kevin Buzzard (May 06 2022 at 13:51):

I still have

/home/buzzard/lean-projects/lean-liquid/src/for_mathlib/homotopy_category_pretriangulated.lean:91:13: error: unknown identifier 'splitting_of_is_iso_zero'

Johan Commelin (May 06 2022 at 14:03):

Yeah, I'm not done fixing everything. More errors popping up

Johan Commelin (May 06 2022 at 14:04):

Ok, now it's done. Pushed

Kevin Buzzard (May 06 2022 at 14:14):

Normally I would just think "well someone else broke it and probably they'll fix it soon enough" but because I'm active in pushing to master right now I'm always scared that it's my fault! Looks like it's compiling again -- thanks. I'm about to show it off at the University of Southampton!

Johan Commelin (May 06 2022 at 14:17):

I think Scott's refactor caused rw's to miss out on some type class inferences.

Scott Morrison (May 06 2022 at 23:07):

Sorry. :-( I though I let leanpkg build run to completion, but maybe I made further changes afterwards.

Kevin Buzzard (May 16 2022 at 17:21):

for_mathlib/is_quasi_iso_sigma.lean is broken for me on master

Adam Topaz (May 16 2022 at 17:23):

fixed..

Adam Topaz (May 16 2022 at 17:24):

oops wait.

Adam Topaz (May 16 2022 at 17:24):

I'm fixing it now...

Adam Topaz (May 16 2022 at 17:26):

Okay, it should be fixed now.

Adam Topaz (May 16 2022 at 17:27):

sorry about that

Kevin Buzzard (May 16 2022 at 21:12):

I'm just always worried it's my fault!

Kevin Buzzard (May 17 2022 at 19:31):

Hmm, I was just editing stuff in src/laurent_measures and now src/laurent_measures/ext.lean isn't compiling for me. I'm hoping this is @Adam Topaz 's fault and unrelated to my changes...

Kevin Buzzard (May 17 2022 at 19:34):

aargh no it is my fault :-/ I'll fix it


Last updated: Dec 20 2023 at 11:08 UTC