Zulip Chat Archive
Stream: lean4
Topic: What does "tactic execution" measure in the speedcenter?
Eric Wieser (Jan 05 2024 at 02:30):
In #9422, the benchmarking script is reporting that a change to a tactic that seems to be used 2-3 times in all of mathlib has increased the tactic runtime by 7.5%. This is pretty strange to me, because the test file that exercises this tactic shows a 4% speed boost.
Is this measuring the sum of the runtimes of all tactics, or just the longest tactic runtime?
Jeremy Tan (Jan 05 2024 at 02:39):
It's the former. The metric has gone from 1298 seconds to 1395 seconds
Jeremy Tan (Jan 05 2024 at 02:44):
Also note that Tactic.CancelDenoms.Core
is imported by Tactic.Linarith.Preprocessing
, and linarith
has a ton of uses in mathlib4
Eric Wieser (Jan 05 2024 at 02:47):
Somehow I missed that import
Eric Wieser (Jan 05 2024 at 02:48):
It's still strange that the test is faster but mathlib is slower
Eric Wieser (Jan 05 2024 at 02:48):
But I guess I should profile the linarith tests too
Eric Wieser (Jan 05 2024 at 11:05):
The linarith test also got marginally faster
Eric Wieser (Jan 05 2024 at 11:06):
So maybe this is bogus? The total build time only increased by 5s
Last updated: May 02 2025 at 03:31 UTC