Zulip Chat Archive

Stream: mathlib4

Topic: !4#3208 merge conflicts


Kevin Buzzard (Apr 16 2023 at 10:49):

I thought I'd try and help with porting CategoryTheory.Limits.Presheaf this PR as it's on the path to a file I want to see ported, but I'm confused by the conflicts. Why are changes in a normed space file anything to do with porting a category theory file?

!4#3208

Scott Morrison (Apr 16 2023 at 10:55):

I agree it is strange. I just had the same merge conflicts on another PR, and just accepting the incoming changes seemed to give the right diff, so I've done that again on this PR for you!

Eric Wieser (Apr 16 2023 at 10:55):

You need to rebase on master

Eric Wieser (Apr 16 2023 at 10:56):

See the "force push" thread

Scott Morrison (Apr 16 2023 at 10:56):

Ugh, still that.

Eric Wieser (Apr 16 2023 at 10:57):

These PRs are tricky, because everyone with a local copy on their machine is affected

Eric Wieser (Apr 16 2023 at 10:58):

So really the "owner" should do the rebase

Eric Wieser (Apr 16 2023 at 11:01):

It would be straightforward for me to fix all of the remaining PRs affected by this on github, but then everyone with a local copy they are working on will end up in a mess if they're not experienced with git

Scott Morrison (Apr 16 2023 at 11:04):

Why don't we straightforwardly fix them all with a merge, instead, so then everyone with a local copy can simply pull?

Scott Morrison (Apr 16 2023 at 11:04):

The rebase is just annoying for everyone else with a copy, while the merge solves the problem, no?

Eric Wieser (Apr 16 2023 at 11:10):

The merge require manual effort to resolve conflicts, the rebase resolves them automatically

Eric Wieser (Apr 16 2023 at 11:10):

It also makes a mess of the bors author and claims the PR is Jeremy's... (Along with 12 or so other people)


Last updated: Dec 20 2023 at 11:08 UTC