Zulip Chat Archive

Stream: mathlib4

Topic: AlgHom kernel


Artie Khovanov (Jul 21 2025 at 22:14):

In a few places in the library (eg Mathlib.RingTheory.FinitePresentation), there is extensive use of RingHom.ker f.toRingHom, where f is an AlgHom. However, RingHom.ker takes a RingHomClass, so the .toRingHom is redundant.
Am I OK to refactor it out, or is this usage somehow secretly load-bearing?

Eric Wieser (Jul 21 2025 at 22:26):

This is the thing I was describing in the other thread; arguably it was a design error to define RingHom.ker to take RingHomClass

Artie Khovanov (Jul 21 2025 at 22:26):

OK I won't touch it unless I have to


Last updated: Dec 20 2025 at 21:32 UTC