Zulip Chat Archive
Stream: mathlib4
Topic: CI: duplicate check for case collisions
Michael Rothgang (Jul 22 2024 at 15:59):
The "style lint" step of the build
workflow currently checks twice if there are different files whose lower-case name is different: once by calling in the case checker action action, and again in lint-style.sh
(just for the .lean files). Is there a reason for this duplication? Can one of them be removed?
For just the .lean files, the check is easy to rewrite in Lean (which would remove a dependency on an external action, which I consider a small plus in principle): that said, if checking the entire repo is useful, I also understand.
Johan Commelin (Jul 22 2024 at 17:08):
I guess some os's get into trouble if such a clash occurs?
Johan Commelin (Jul 22 2024 at 17:08):
So let's check the whole repo and dedup the linting
Michael Rothgang (Jul 22 2024 at 17:13):
Johan Commelin said:
I guess some os's get into trouble if such a clash occurs?
Windows, I believe
Michael Rothgang (Jul 22 2024 at 17:13):
(Though just for building mathlib, perhaps that's not an issue...)
Michael Rothgang (Jul 22 2024 at 17:25):
Last updated: May 02 2025 at 03:31 UTC