Zulip Chat Archive

Stream: mathlib4

Topic: Closing obsolete PRs


Michael Rothgang (May 24 2024 at 20:27):

Every now and then, I stumble across some PR that is now obsolete. (Usually via some Github search that is not #queue.) I'm inclined to comment (why they're superseded, thanking the author for their contribution) and close them; any objections if I do so?
Would a dedicated thread for recording such PRs be useful, as a "triage paper trail", so to say?

Patrick Massot (May 24 2024 at 20:35):

I think you should ask in the reviewer stream first. There may be a complicated history.

Kim Morrison (May 24 2024 at 21:48):

But yes, I think we are unnecessarily allergic to closing old obsolete stuff, and I think it would be good if we improved processes so reviewers agreed on when closing was appropriate, and then did it more!

Richard Osborn (May 24 2024 at 22:17):

They can always be re-opened as well.


Last updated: May 02 2025 at 03:31 UTC