Zulip Chat Archive

Stream: mathlib4

Topic: Consistent naming scheme in Data/Set/Card


metakuntyyy (Jan 28 2026 at 04:00):

Take a look at the following two theorems https://leanprover-community.github.io/mathlib4_docs/Mathlib/Data/Set/Card.html#Set.InjOn.encard_image and https://leanprover-community.github.io/mathlib4_docs/Mathlib/Data/Set/Card.html#Set.ncard_image_of_injOn. It would be good if we could have a consistent naming scheme. I barely found the second one.

Or https://leanprover-community.github.io/mathlib4_docs/Mathlib/Data/Set/Card.html#Function.Injective.encard_image and https://leanprover-community.github.io/mathlib4_docs/Mathlib/Data/Set/Card.html#Set.ncard_image_of_injective. This is very confusing.

How should we rename those?

metakuntyyy (Jan 28 2026 at 04:02):

Regarding the first, I'd prefer Set.InjOn.encard_image and the second I'd prefer Function.Injective.encard_image. I think those are nicer to type.

metakuntyyy (Jan 29 2026 at 23:36):

#34589 opened for the first one.


Last updated: Feb 28 2026 at 14:05 UTC