Zulip Chat Archive

Stream: mathlib4

Topic: Data.Bitvec.Basic !4#2179


Shreyas Srinivas (Feb 09 2023 at 16:28):

Thread for discussions about this PR

Eric Wieser (Feb 09 2023 at 16:31):

Note that this file was modified a month ago in #18131 in a way that depends on changes in port-status#data/fin/basic which haven't yet been forward-ported

Eric Wieser (Feb 09 2023 at 16:31):

I opened the forward-port PR a few hours ago at !4#2178.

Eric Wieser (Feb 09 2023 at 16:35):

port-status#data/bitvec/basic will shortly (~30 minutes) tell you the other problem: that the imports were recently changed in mathlib3, and you used mathport output from before that change propagated.

Shreyas Srinivas (Feb 09 2023 at 16:52):

uh oh

Shreyas Srinivas (Feb 09 2023 at 16:52):

What's the standard fix?

Shreyas Srinivas (Feb 09 2023 at 16:53):

The PR can't proceed without the ac_mono tactic in any case.

Eric Wieser (Feb 09 2023 at 17:12):

I would say the fix is wait for !4#2178, and wait for mathlib3port to rerun (which it does twice a day IIRC)


Last updated: Dec 20 2023 at 11:08 UTC