Zulip Chat Archive

Stream: mathlib4

Topic: Field.toEuclideanDomain creates data


Johan Commelin (Mar 12 2024 at 16:33):

I noticed today that docs#Field.toEuclideanDomain creates data, namely the quotient and remainder functions (and the relation r) for fields. This goes against the "forgetful inheritance" doctrine. So far it doesn't seem to cause trouble in mathlib, but I wonder if we should try to fix this?

Yaël Dillies (Mar 12 2024 at 18:25):

I don't think it matters since fields are very boring euclidean domains

Yaël Dillies (Mar 12 2024 at 18:25):

As in, I don't think there's much reasoning to be done about the euclidean domain structure of a field

Matthew Ballard (Mar 12 2024 at 18:26):

Is that instance used anywhere?

Johan Commelin (Mar 12 2024 at 20:10):

No idea. But probably we should make it a def, just to be sure.

Eric Rodriguez (Mar 12 2024 at 20:12):

I worry that will cause more issues than the possible footguns, however :/


Last updated: May 02 2025 at 03:31 UTC