Zulip Chat Archive

Stream: mathlib4

Topic: Fin in std4


Ruben Van de Velde (Jul 14 2023 at 08:34):

The mess with "moving" Fin lemmas to std4 is only getting worse. First it took over the names of a whole bunch of bundled definitions for unbundled versions of the same, and now definitions that existed in mathlib like succAbove have just disappeared with no apparent replacement, and Fin.val_zero no longer works. Can we just revert everything to a working state rather than blocking std4 updates?

Eric Wieser (Jul 14 2023 at 08:37):

#5847 is some of the context here I assume?

Mario Carneiro (Jul 14 2023 at 13:11):

Ruben Van de Velde said:

The mess with "moving" Fin lemmas to std4 is only getting worse. First it took over the names of a whole bunch of bundled definitions for unbundled versions of the same, and now definitions that existed in mathlib like succAbove have just disappeared with no apparent replacement, and Fin.val_zero no longer works. Can we just revert everything to a working state rather than blocking std4 updates?

Definitions that "disappeared with no apparent replacement" were not ported. Don't delete them from mathlib

Mario Carneiro (Jul 14 2023 at 13:13):

As for val_zero, we want both versions, and I suggest renaming the mathlib theorem to val_zero'


Last updated: Dec 20 2023 at 11:08 UTC