Zulip Chat Archive
Stream: mathlib4
Topic: Finset.filter_congr_decidable
Yaël Dillies (Sep 09 2023 at 21:25):
docs3#finset.filter_congr_decidable was optimistically no-aligned with the following message:
-- Porting note: likely no longer relevant with `Bool`s
Let me just tell you that this is wrong, since I'm currently fixing some regressions in #7021.
Eric Wieser (Sep 09 2023 at 21:33):
This is because filter at one point took its predicate as a bool
Yaël Dillies (Sep 09 2023 at 21:36):
How was that supposed to fix anything?
Eric Wieser (Sep 09 2023 at 21:40):
When the filtering was by bool, there was no decidable argument, which is why the lemma was removed
Eric Wieser (Sep 09 2023 at 21:40):
Then we changed it back but forgot to re-add the lemma
Yaël Dillies (Sep 09 2023 at 21:41):
Hmm... okay
Last updated: Dec 20 2023 at 11:08 UTC