Zulip Chat Archive

Stream: mathlib4

Topic: IsDiscreteValuationRing


Filippo A. E. Nuccio (Dec 12 2024 at 14:48):

In #18774 LocalRing has been (rightly) renamed to IsLocalRing, because it is Prop-valued. Given the definition of a docs#DiscreteValuationRing, I would propose that we also rename DiscreteValuationRing to IsDiscreteValuationRing. Any objection?

Filippo A. E. Nuccio (Dec 16 2024 at 21:18):

OK, the PR is ready #19947

Filippo A. E. Nuccio (Dec 16 2024 at 21:19):

I can post this in the PR reviewschannel, but perhaps here is enough.

Kevin Buzzard (Dec 16 2024 at 22:04):

I can't believe I called it that -- this is one of my pet hates nowadays! Yes please let's call it Is!


Last updated: May 02 2025 at 03:31 UTC