Zulip Chat Archive
Stream: mathlib4
Topic: MeasureTheory.PiSystem !4#2160
Johan Commelin (Feb 11 2023 at 08:14):
-- porting note: changed `max`/`min` to `⊔`/`⊓`
Is this what we want?
Pol'tta / Miyahara Kō (Feb 11 2023 at 08:25):
When we used max
/min
, the a₁ ⊔ a₂ =?= max a₁ a₂
at isPiSystem_Icc_mem
and isPiSystem_Icc
failed, so we changed max
/min
to ⊔
/⊓
in the theorems. Should we wait for a core-PR to fix this?
Johan Commelin (Feb 11 2023 at 08:32):
Did the definition of either of the two change?
Johan Commelin (Feb 11 2023 at 08:34):
@Pol'tta / Kô Miyahara Do you mean that the statement no longer typechecked? Or was it just the proof that broke?
Pol'tta / Miyahara Kō (Feb 11 2023 at 09:00):
The statement was typechecked, but Lean couldn't match Icc_inter_Icc : Icc a₁ b₁ ∩ Icc a₂ b₂ = Icc (a₁ ⊔ a₂) (b₁ ⊓ b₂)
to Icc a₁ b₁ ∩ Icc a₂ b₂ = Icc (max a₁ a₂) (min b₁ b₂)
.
Johan Commelin (Feb 11 2023 at 09:02):
If the statement typechecks, then we should fix the proof. Rewrite with a lemma max_eq_sup
or something like that.
Last updated: Dec 20 2023 at 11:08 UTC