Zulip Chat Archive

Stream: mathlib4

Topic: Missing Lean 4 defs


Arien Malec (Dec 01 2022 at 20:58):

After some digging, I'm dependent on a notation for $> that used to be in Lean 3, tagged to functor.map_const_rev that used to be in init.control.functor & this is used all over the place in mathlib

Mario Carneiro (Dec 01 2022 at 20:58):

ok so add it like infix " $> " => Functor.mapConstRev

Arien Malec (Dec 01 2022 at 21:00):

which is also missing.

Arien Malec (Dec 01 2022 at 21:00):

pretty trivial to def tho.

Arien Malec (Dec 01 2022 at 21:01):

Should we add it to mathlib, or upstream?

Arien Malec (Dec 01 2022 at 21:04):

Looks like @Ruben Van de Velde did this in place.

Ruben Van de Velde (Dec 01 2022 at 21:04):

Yeah, should still move it somewhere, probably. Let's keep it in mathlib, though

Arien Malec (Dec 01 2022 at 21:05):

Probably should move to Control.Functor, yeah?

Arien Malec (Dec 01 2022 at 21:06):

I think we also want the notation, or else lots of downstream stuff in mathlib will break.

Arien Malec (Dec 01 2022 at 21:07):

I'll do a mini-PR for this...

Ruben Van de Velde (Dec 01 2022 at 21:08):

I also moved it in mathlib4#803, but feel free to do it separately if you prefer

Arien Malec (Dec 01 2022 at 21:09):

easier your way...


Last updated: Dec 20 2023 at 11:08 UTC