Zulip Chat Archive

Stream: mathlib4

Topic: Naming `subset_insert_iff` for Set and Finset


SnO2WMaN (May 03 2025 at 04:31):

Currently, Finset.subset_insert_iff states that s ⊆ insert a t ↔ s.erase a ⊆ t. However, Set.subset_insert_iff states that s s ⊆ insert x t ↔ s ⊆ t ∨ x ∈ s ∧ s \ {x} ⊆ t. I think this naming is confusing because I thought it should be same (or similar) statement (and maybe, there's no similar Finset's statement for Set), and perhaps, it doesn't seem to be following mathlib's naming convention. I thought these should be renamed, how about?

Yury G. Kudryashov (May 03 2025 at 04:35):

The similar statement is true for Sets.

Yury G. Kudryashov (May 03 2025 at 04:35):

We should sync the API here, probably renaming the current Set statement to something like subset_insert_cases


Last updated: Dec 20 2025 at 21:32 UTC