Zulip Chat Archive

Stream: mathlib4

Topic: No `--wfail` when building archive


Daniel Weber (Nov 30 2024 at 09:27):

Is the lack of --wfail when building Archive and Counterexamples intentional? (It's still caught by the "check for noisy stdout lines" CI step)

Ruben Van de Velde (Nov 30 2024 at 09:31):

Oversight, I think

Damiano Testa (Nov 30 2024 at 10:04):

Archive and Counterexamples are independent of each other, I think, so building both, even if they fail, can give useful information.

Michael Rothgang (Nov 30 2024 at 10:13):

#19633 adds --wfail

Michael Rothgang (Nov 30 2024 at 10:15):

The archive and counterexamples are built as separate steps... ah, but by default the former step failing means the latter will be skipped. Ok, that should be added.

Damiano Testa (Nov 30 2024 at 10:32):

The end result is not much different, though, right? Both get build and either one failing is flagged.

Michael Rothgang (Nov 30 2024 at 10:44):

Sure! If adding --wfail makes somebody less puzzled when looking at the file, I consider that an improvement. If adding some if condition to a workflow step is confusing again, perhaps it's less relevant.


Last updated: May 02 2025 at 03:31 UTC