Zulip Chat Archive
Stream: mathlib4
Topic: Non-terminal simps in `GroupTheory.Coxeter.Inversion`
Kim Morrison (Jun 12 2024 at 04:06):
Similarly, a non-terminal simp
in theorem getD_rightInvSeq_mul_self
in Mathlib.GroupTheory.Coxeter.Inversion
just got in my way!
@Mitchell Lee or anyone else, would you be able to fix these up?
Kim Morrison (Jun 12 2024 at 04:07):
I can switch to a different branch and simp?
and replace myself, of course, but I would like to note these things as they occur as a reminder that getting these things right really does make a difference to maintenance!
Mitchell Lee (Jun 12 2024 at 07:05):
Yes, I will do it tomorrow
Mitchell Lee (Jun 12 2024 at 23:27):
I did it: #13787
Thanks for telling me about this.
Kim Morrison (Jun 12 2024 at 23:53):
And thanks very much for fixing it! :-)
Michael Rothgang (Jun 13 2024 at 08:14):
And there was even a tiny speed-up as a result: http://speed.lean-lang.org/mathlib4/run-detail/1dc401b2-67ba-4c95-94cb-9b0626d5b8f2
Last updated: May 02 2025 at 03:31 UTC