Zulip Chat Archive
Stream: mathlib4
Topic: PSA: broken diff selection on github
Eric Wieser (Apr 29 2023 at 09:37):
The usual "look at the diff between commits[3]
and commits[-1]
approach" to ported files is still possible on github, but the UI for it is broken. If you try and shift click in the commit view, it generates a broken URL with 8-character SHAs.
Thankfully it still works if you replace those short SHAs with the full 40-character SHAs.
Eric Wieser (Apr 29 2023 at 10:00):
Hmm, it seems I might have just hit a (short) SHA collision which Github handles incorrectly
Eric Wieser (Apr 29 2023 at 10:02):
Can anyone else reproduce on !4#3716?
Last updated: Dec 20 2023 at 11:08 UTC