Zulip Chat Archive

Stream: mathlib4

Topic: Porting Dlist.lean


Shreyas Srinivas (Dec 23 2022 at 23:59):

Hi everyone,
I am next trying to port Dlist.lean (https://github.com/leanprover-community/lean3port/blob/master/Leanbin/Data/Dlist.lean) . Again this is not yet taken on #port-status
Although this is part of lean core, it seems to lie outside the Init folder. I don't see an equivalent folder inside mathlib4. Where should this file go?

Shreyas Srinivas (Dec 24 2022 at 00:01):

I noticed that this looks like something that should be in std even though it is on the mathlib4 port queue.

Eric Wieser (Dec 25 2022 at 14:06):

I think the default is to port to mathlib unless someone's says otherwise. It can always be moved to std4 later

Mario Carneiro (Dec 25 2022 at 14:35):

Indeed, even if it's intended for std I think these developments should go through mathlib4 first, so we can make sure it's working alright and does what it needs to.

Shreyas Srinivas said:

Although this is part of lean core, it seems to lie outside the Init folder. I don't see an equivalent folder inside mathlib4. Where should this file go?

Mathlib.Data.DList

Shreyas Srinivas (Dec 25 2022 at 14:58):

This clashes with the data.dlist inside mathlib https://github.com/leanprover-community/mathlib/tree/master/src/data/dlist

Mario Carneiro (Dec 25 2022 at 14:58):

That's not a file

Shreyas Srinivas (Dec 25 2022 at 15:25):

I just checked and noticed that DList/Basic.lean has been ported. It replaces the import Data.Dlist line with import Std.Data.DList so it doesn't dlist from core anymore

Shreyas Srinivas (Dec 25 2022 at 15:26):

This suggests that Std already has the dlist port and can be used in dlist related mathlib files

Shreyas Srinivas (Dec 25 2022 at 15:29):

Is there a way to check what files depend on dlist?

Mario Carneiro (Dec 25 2022 at 15:38):

Whether or not an upstream file exists, mathlib wants a file with #aligns in it

Mario Carneiro (Dec 25 2022 at 15:39):

and that file should exist at the same place it does in lean3/mathlib in the file hierarchy

Shreyas Srinivas (Dec 25 2022 at 15:57):

okay. makes sense

Pol'tta / Miyahara Kō (Jun 14 2023 at 01:52):

I've removed the porting comment "Waiting on tactic abstract" because definitions with abstract are already defined in Std.

Mario Carneiro (Jun 14 2023 at 01:52):

that's news to me

Mario Carneiro (Jun 14 2023 at 01:53):

er, you mean that the definitions have been upstreamed, not the abstract tactic

Pol'tta / Miyahara Kō (Jun 14 2023 at 01:58):

Yes. abstract tactic is not ported yet.


Last updated: Dec 20 2023 at 11:08 UTC