Zulip Chat Archive
Stream: mathlib4
Topic: Push_neg port
Alice Laroche (Feb 13 2022 at 18:20):
I made a pull request with a port of the push_neg tactic
https://github.com/leanprover-community/mathlib4/pull/193
Kevin Buzzard (Feb 13 2022 at 21:35):
Thank you!
Arthur Paulino (Mar 20 2022 at 16:18):
Alice ended up closing the PR (mathlib4#193). Can someone help me understand why?
- Was the approach inadequate in a more fundamental level? or
- The approach was correct but had some missing cases?
Gabriel Ebner (Mar 21 2022 at 07:55):
See my comments. I think fundamentally it's the approach that we want. But it constructs congruence lemmas incorrectly, so it will fail on decide
, ite
, etc. It would also be good to use the Simp.Result
API because that simplifies the code quite a bit.
Last updated: Dec 20 2023 at 11:08 UTC