Zulip Chat Archive
Stream: mathlib4
Topic: Splitting `OperatorNorm.lean`
David Loeffler (Feb 26 2024 at 21:15):
I had some lemmas I wanted to add to Analysis/NormedSpace/OperatorNorm.lean
, and I got so fed up with trying to understand the layout of that file (a 2300-line overgrown tangled mess) that I found myself splitting it up into 8 smaller files.
I've posted a PR for the split at #10990 – there are no changes to the code, just moving stuff around. I'd be very grateful for a quick review of this PR if possible, since large-file-split PRs are liable to bit-rot very quickly.
Ruben Van de Velde (Feb 26 2024 at 21:16):
Is " feat(Analysis/NormedSpace): operator norm of fst / snd projn" supposed to be in there?
Johan Commelin (Feb 26 2024 at 21:17):
8 smaller files, of which the smallest is 600 lines.
Do you mean s/smallest/largest/
?
Ruben Van de Velde (Feb 26 2024 at 21:17):
Ruben Van de Velde said:
Is " feat(Analysis/NormedSpace): operator norm of fst / snd projn" supposed to be in there?
Oh, I didn't read the PR summary
David Loeffler (Feb 26 2024 at 21:17):
Ruben Van de Velde said:
Is " feat(Analysis/NormedSpace): operator norm of fst / snd projn" supposed to be in there?
It isn't there. I reverted those changes in a later commit but the commit message is still there.
David Loeffler (Feb 26 2024 at 21:18):
Ruben Van de Velde said:
Oh, I didn't read the PR summary
No, I just added that remark after your message :-)
David Loeffler (Feb 26 2024 at 21:19):
Johan Commelin said:
8 smaller files, of which the smallest is 600 lines.
Do you mean
s/smallest/largest/
?
8 x 600 > 2300 :smile:
Patrick Massot (Feb 26 2024 at 21:26):
And people say that modern number theorists can’t do actual numbers…
David Loeffler (Feb 26 2024 at 22:18):
Thanks Ruben and Johan for the super-quick responses!
Last updated: May 02 2025 at 03:31 UTC