Zulip Chat Archive
Stream: mathlib4
Topic: Splitting docs#Set.instCoeSortType to its own file?
Anne Baanen (Nov 14 2024 at 12:19):
I opened PR #19031 which moves docs#Set.instCoeSortType to its own file from Data.Set.Operations
. This was needed in #18619 because there are a few files that import docs#Finite but have an assert_not_exists
against importing docs#Set.range. For example, file#Mathlib/Algebra/Group/Int. @Yaël Dillies rightfully pointed out that Data.Set.Operations
is already quite minimal, so it shouldn't need further splitting unless really well motivated.
What do we think? Should we split that file further, or remove the assert_not_exists
Yuyang Zhao (Nov 14 2024 at 17:51):
Is there any reason not to put it in Mathlib.Data.Set.Defs
?
Last updated: May 02 2025 at 03:31 UTC