Zulip Chat Archive
Stream: mathlib4
Topic: aligns for refactored content
Eric Rodriguez (Jul 21 2023 at 15:25):
For mathlib4-only refactors, what should we do with aligns to what stuff was in the past?
Eric Rodriguez (Jul 21 2023 at 15:26):
what if the content changes a bit of a lemma but not a lot?
Yury G. Kudryashov (Jul 21 2023 at 21:05):
IMHO, if #align
will help someone who ports a project based on mathlib
, then it should stay (possibly, with the \_x
suffix).
Scott Morrison (Jul 22 2023 at 07:35):
Let's not use the ₓ
suffix, it is not particularly helpful as a warning (everyone already knows that not everything matches up cleanly, and just having an ₓ
doesn't give much extra information), and ends up being just noise.
Writing comments, however, is great. :-)
But I certainly agree we should keep the #align's, even as they become approximate hints. I still use grep for #align.*XYZ
sometimes.
Eric Rodriguez (Jul 22 2023 at 08:06):
It's actually kind of nice to be able to search for fully qualified names. I wonder if we could do this for all theorems somehow
Last updated: Dec 20 2023 at 11:08 UTC