Zulip Chat Archive
Stream: mathlib4
Topic: awaiting-author label was not removed
Etienne Marion (Jan 28 2026 at 21:24):
In #34542 the awaiting-author label was not removed after the author commented -awaiting-author. I am guessing this is not normal, can somebody have a look please?
Bryan Gin-ge Chen (Jan 28 2026 at 21:28):
Next to the author's comment, there's a "View reviewed changes" link, so I think that it's actually a "pull request review" not an ordinary comment on the PR. I'll look into making the bot respond to reviews and review comments as well.
Etienne Marion (Jan 28 2026 at 21:30):
Thanks I did not notice that! It is unexpected that one would deal with labels through review comments.
Bryan Gin-ge Chen (Jan 28 2026 at 21:31):
Indeed, the fact that there are 3 types of these comment-adjacent things has been the source of many headaches in our workflows...
Bryan Gin-ge Chen (Jan 28 2026 at 21:38):
#34549 should make the bot trigger on reviews + review comments as well.
Last updated: Feb 28 2026 at 14:05 UTC