Zulip Chat Archive
Stream: mathlib4
Topic: data.rat.cast mathlib4#1261
Ruben Van de Velde (Dec 29 2022 at 21:48):
This one unsurprisingly has a bunch of issues. Help very much welcome
Siddhartha Gadgil (Dec 31 2022 at 04:40):
I have "fixed" many of the issues, but it has to be checked if the fix is correct.
- In many cases theorems with
norm_cast
attribute had no casting, so I removed the attribute (should the statement be changed instead?) - A couple of proofs that were
by norm_cast
needed to userw
andapply
with specific lemmas (which were no longernorm_cast
- In one case a statement had to be made more explicit.
Siddhartha Gadgil (Dec 31 2022 at 04:54):
All errors are now fixed. However someone should review to see that there is no accidental change in statement meanings.
Last updated: Dec 20 2023 at 11:08 UTC