Zulip Chat Archive

Stream: mathlib4

Topic: delete mathport syntax when porting?


Thomas Murrills (Feb 17 2023 at 07:58):

I just want to confirm: when we port a tactic and move tactic syntax from Syntax.lean, do we also delete that syntax from Syntax.lean?

(If so, somehow I've missed that part of the procedure this whole time...whoops :upside_down:)

Thomas Murrills (Feb 17 2023 at 08:03):

Ok, judging by past PR's, I think I know the answer...

Moritz Doll (Feb 17 2023 at 08:20):

You are also supposed to import your tactic at the top of Syntax.lean, so you would get an error if you don't delete the syntax in the file.

Thomas Murrills (Feb 17 2023 at 08:45):

Fixed a couple: !4#2343


Last updated: Dec 20 2023 at 11:08 UTC