Zulip Chat Archive

Stream: mathlib4

Topic: import-graph lookahead


Moritz Doll (Nov 21 2022 at 07:06):

I don't know whether anyone else would be interested in this, but I think it might be neat if we had a option to ask the import-graph script to add the next n (I only care about n=1) dependencies below the --to node. The reason for this is that if I port a file, I can look whether that port immediately makes another file portable and then it is easier to port multiple files at once.

Andrew Yang (Nov 21 2022 at 07:13):

As an alternative, this information is already available in the docs; you can click on "Imported by" on the right sidebar. But I agree that this would be a useful extension to the script.

Moritz Doll (Nov 21 2022 at 07:13):

but "imported by" does not tell you whether the other dependencies are ported yet

Moritz Doll (Nov 21 2022 at 07:16):

I guess I could run the script for every file in "imported by", but this is a bit more tedious

Patrick Massot (Nov 21 2022 at 07:30):

I'm not sure I understand what you want. Do you want to add only one level of edges beyond the given nodes or also all the ancestors of the successors of the given node?

Moritz Doll (Nov 21 2022 at 07:35):

I am not too interested in seeing what the ancestors are (I am afraid that is too messy). Ideally they are not shown, but the successors are colored depending on their portability once the --to node is green.

Moritz Doll (Nov 21 2022 at 07:36):

i.e., all successors that only depend on --to and already ported files are blue, and if there exists an unported ancestor that is not --to then it is white

Patrick Massot (Nov 21 2022 at 08:28):

Ok, the difficult part is to come up with a name for the command line option trigerring this behavior

Moritz Doll (Nov 21 2022 at 08:50):

I am really bad with naming things, but maybe "--show-children"?


Last updated: Dec 20 2023 at 11:08 UTC