Zulip Chat Archive

Stream: mathlib4

Topic: leLT, ltLe, and other naming weirdness


Violeta Hernández (Oct 10 2024 at 07:52):

Consider the following:

Violeta Hernández (Oct 10 2024 at 07:52):

The naming scheme on display is all over the place, regarding capitalization of le/lt and usage of equiv/eq

Violeta Hernández (Oct 10 2024 at 07:53):

These definitions aren't even about order relations, mind you, but about compositions of, docs#InitialSeg (le), docs#PrincipalSeg (lt), and docs#RelIso (eq)

Violeta Hernández (Oct 10 2024 at 07:57):

I get what's being done here, but I feel like this just doesn't jive with our usual naming conventions. I'm not really sure how to rename these, though.

Eric Wieser (Oct 10 2024 at 08:59):

The first two look like they should be compInitial and similar

Violeta Hernández (Oct 10 2024 at 09:57):

Maybe transInitial instead? I think we generally use trans and such for embeddings like these

Eric Wieser (Oct 10 2024 at 10:12):

Sure, though watch out for the order reversal between comp and trans!

Violeta Hernández (Oct 10 2024 at 23:08):

So here's my suggestion

Violeta Hernández (Oct 21 2024 at 03:21):

#17989


Last updated: May 02 2025 at 03:31 UTC