Zulip Chat Archive
Stream: mathlib4
Topic: mul_equiv.Pi_congr_right_refl
Winston Yin (Dec 05 2022 at 08:15):
Is there any reason why mul_equiv.Pi_congr_right_refl
, mul_equiv.Pi_congr_right_symm
, mul_equiv.Pi_congr_right_trans
don't have to_additive
attribute, while mul_equiv.Pi_congr_right
does?
Winston Yin (Dec 05 2022 at 08:15):
The attribute can be added without error, so unless there's some special reason, I'm going to add to_additive
back in during porting algebra.hom.equiv.basic
Ruben Van de Velde (Dec 05 2022 at 08:21):
Did it exist in 3 and not get ported?
Winston Yin (Dec 05 2022 at 08:26):
It didn’t exist in 3. See docs#mul_equiv.Pi_congr_right_refl but there’s no add_equiv. Pi_congr_right_refl
Eric Wieser (Dec 05 2022 at 08:53):
Why not make a PR to mathlib 3 to add it?
Kevin Buzzard (Dec 05 2022 at 09:45):
That way you'll find out if it causes any problems
Last updated: Dec 20 2023 at 11:08 UTC