Zulip Chat Archive

Stream: mathlib4

Topic: rename `Inducing` and `Embedding`?


Yury G. Kudryashov (Aug 16 2024 at 14:46):

What do you think about renaming Inducing and Embedding to TopologyInducing and TopologyEmbedding, resp.?

Yaël Dillies (Aug 16 2024 at 14:48):

I agree they need to be renamed, but I disagree with your suggestion. Here's a list of my requests:

  1. Make them be under the Topology namespace
  2. Make it clear they are Prop-valued. Compare to docs#Function.Embedding which is Type-valued.

Yury G. Kudryashov (Aug 16 2024 at 14:48):

Or should I use IsTopologyInducing?

Yaël Dillies (Aug 16 2024 at 14:49):

Hence I would suggest Topology.IsInducing, Topology.IsEmbedding

Yury G. Kudryashov (Aug 16 2024 at 14:49):

We didn't use Topology as a namespace to be opened w/o scoped yet.

Yury G. Kudryashov (Aug 16 2024 at 14:49):

But probably we should (and move some stuff from TopologicalSpace NS)

Yaël Dillies (Aug 16 2024 at 14:50):

Yury G. Kudryashov said:

We didn't use Topology as a namespace to be opened w/o scoped yet.

Have we not? I thought we had already moved some things in that namespace

Yury G. Kudryashov (Aug 16 2024 at 14:51):

Possibly, I missed this.

Patrick Massot (Aug 16 2024 at 15:37):

As I already wrote several times, I'm in favor or namespacing those definitions. Their current status is a historical accident.

Yury G. Kudryashov (Aug 16 2024 at 17:50):

I started working on this, I hope to open a PR over the weekend.


Last updated: May 02 2025 at 03:31 UTC