Zulip Chat Archive
Stream: mathlib4
Topic: renaming incorrect names?
Thomas Murrills (Feb 15 2023 at 22:39):
I found an incorrectly named identifier in mathlib4; is the general policy to leave those as-is (at least for now), or should I PR? It's relatively minor, so I just wanted to check if it's worth it right now. (the identifier is mkpair
, which should be mkPair
)
Eric Wieser (Feb 15 2023 at 23:01):
Fixing mis-ported names is definitely a good thing to do
Eric Wieser (Feb 15 2023 at 23:02):
Fixing mis-ported names is definitely a good thing to go
Thomas Murrills (Feb 16 2023 at 20:48):
!4#2324 :)
Last updated: Dec 20 2023 at 11:08 UTC