Zulip Chat Archive
Stream: mathlib4
Topic: to_additive and extends
Floris van Doorn (Nov 20 2024 at 18:49):
Regular users of to_additive
will know that it didn't manage to automatically translate instances generated by the extends
clause. This is fixed in #19302.
If someone could help removing all the manual attribute declarations, that would be great! (I just did one file; to_additive
will complain for all attributes that should be removed).
Ruben Van de Velde (Nov 20 2024 at 18:59):
Looking
Floris van Doorn (Nov 20 2024 at 20:01):
Thanks! That was a lot fewer errors than I expected. I guess it makes sense: for ring-like classes to_additive
doesn't work anyway.
Floris van Doorn (Nov 20 2024 at 20:02):
The PR above is now ready for review.
Last updated: May 02 2025 at 03:31 UTC