Zulip Chat Archive

Stream: mathlib4

Topic: waits requested


Scott Morrison (May 24 2023 at 16:29):

I just cleaned up #port-comments to remove wait requests where the PR has been merged. At the same time I add the wait-requested-on label to every mathlib3 PR for which there is a current request that a port wait for it.

These PRs are listed here, and the intersection with the #queue is here. It would be nice to clear these out of the way, so reviews are encouraged! :-)

Eric Wieser (May 24 2023 at 16:45):

Good thinking! I suppose a natural follow-up would be to have the dashboard read these labels directly, but that's maybe not worth the work

Scott Morrison (May 24 2023 at 17:50):

Hopefully not. :-)

Scott Morrison (May 27 2023 at 17:01):

Summarising the status of the wait requested list:

  • #19073 is ready for review, with review requested from @Yury G. Kudryashov
  • #18913 is ready for review
  • #18649 and #18755 are awaiting-author @Moritz Doll
  • #19008 is awaiting-author @Apurva Nakade
  • #19049 and #18843 are WIP @Eric Wieser

It would be nice to get this list emptied, and then have it stay that way!

Yury G. Kudryashov (May 27 2023 at 17:04):

I will review once I add missing docstrings to deriv/*.lean

Yury G. Kudryashov (May 27 2023 at 17:15):

#19113 is blocking porting of large parts of calculus.

Yury G. Kudryashov (May 27 2023 at 17:15):

Ready for review modulo missing imports in a test. I'll fix it once I get oleans from CI

Yury G. Kudryashov (May 27 2023 at 17:20):

#19073 is on the queue

Yaël Dillies (May 27 2023 at 17:24):

Don't count me in. I have my final exams in a week

Yury G. Kudryashov (May 27 2023 at 17:25):

@Yaël Dillies Good luck!

Eric Wieser (May 27 2023 at 17:42):

Both my WIP PRs above are to leaf files, so hopefully there's no great rush to finish them; though #19049 should be easy to get over the line

Yury G. Kudryashov (May 28 2023 at 04:07):

Mathport finished, so I'm working on deriv/* now.

Moritz Doll (May 28 2023 at 04:30):

my two PRs in a file that has exactly one dependent file so not very high priority, but I try to finish them as soon as I can.

Eric Wieser (May 28 2023 at 17:43):

#19049 is now maintainer-merged


Last updated: Dec 20 2023 at 11:08 UTC