Zulip Chat Archive
Stream: batteries
Topic: Union and SDiff instances for Std.RBSet
thelissimus (Apr 30 2024 at 05:31):
Hello. I was using Std.RBSet
and couldn't find Union
and SDiff
instances, even though there are union
and sdiff
function implementations. Is there any reason that there are no instances (like API stability or something)? If not, I can make a PR, adding the instances. Figured, I would ask here beforehand, instead of creating redundant PRs and wasting reviewer's time.
Ruben Van de Velde (Apr 30 2024 at 06:02):
I think these classes only recently moved somewhere std can use them
thelissimus (Apr 30 2024 at 06:51):
I was guided by the instance of Union
on the Std.List
. Looking at git history, I was able to trace the addition of the instance to 2 years ago: commit.
So, is it okay if I make a PR?
Last updated: May 02 2025 at 03:31 UTC