Zulip Chat Archive

Stream: batteries

Topic: bump PR


Kim Morrison (Apr 30 2024 at 23:21):

https://github.com/leanprover/std4/pull/772 is the latest bump PR. Hopefully this is the last or second last before v4.8.0-rc1. Once this is merged I will open the PR from bump/v4.8.0 to main for final re-review!

Kim Morrison (May 01 2024 at 03:16):

@Mario Carneiro, I've fixed the test and responded re: the Init files. I'm inclined to hope the Init files just aren't needed in future, but will happily add them if that results in this getting merged quickly. :-)

Mario Carneiro (May 01 2024 at 03:17):

I'm pretty sure one of them is re-added in an open PR, so this seems like wishful thinking :)

Mario Carneiro (May 01 2024 at 03:18):

I think it is actually inevitable to need them, there will always be some theorems which are needed for some *.Basic files

Mario Carneiro (May 01 2024 at 03:18):

Perhaps these get upstreamed, but there is no particular reason to expect they are always wanted

Mario Carneiro (May 01 2024 at 03:20):

The other disruptive aspect of removing these files is that removing files is technically a breaking change, it causes downstream users' import lines to break

Mario Carneiro (May 01 2024 at 03:20):

I really hope we get better tools for managing import migration and removal

Kim Morrison (May 01 2024 at 03:21):

I disagree about needing these files for now, but have added them back to the PR for the sake of getting this out!


Last updated: May 02 2025 at 03:31 UTC