Zulip Chat Archive

Stream: std4

Topic: bump to nightly-2023-07-25


Scott Morrison (Jul 28 2023 at 02:37):

@Mario Carneiro, would you be able to have a quick look at https://github.com/leanprover/std4/pull/202, and see how you feel about having to split out these rws into separate statements. It feels like a bad regression to me, and that we should ask for https://github.com/leanprover/lean4/pull/2317 to be reverted.

François G. Dorais (Jul 28 2023 at 02:43):

It is an annoying regression! There's a lot of code I'll need to patch! Perhaps it can be revised so that prior elaborations saved and tried before attempting to elaborate again.

Scott Morrison (Jul 28 2023 at 03:07):

Pinging @Alex J. Best, too.

Scott Morrison (Jul 28 2023 at 03:08):

I propose making a revert PR, and then trying again with a solution that either tries to reuse elaborations first, or only has this behaviour on at *.

Mario Carneiro (Jul 28 2023 at 03:15):

I agree. An alternative implementation strategy for lean4#2317 is to reassign the metavariables created during elaboration of the term

Scott Morrison (Jul 28 2023 at 06:40):

lean4#2366 is the revert PR.

Alex J. Best (Jul 28 2023 at 07:58):

My mistake, sorry. I should have tested mathlib more with this change. I just didn't forsee that breakage was even possible.

Alex J. Best (Jul 28 2023 at 07:59):

Though Mario's suggestion might be quite easy to implement? Unfortunately I'm at a conference today so can't really look into this myself.


Last updated: Dec 20 2023 at 11:08 UTC