Zulip Chat Archive

Stream: nightly-testing

Topic: MoveAdd


Damiano Testa (Mar 13 2024 at 07:43):

Scott, I identified the source of the issue within MoveAdd: as usual, it is a missing withContext. I don't have time to PR a fix right now, but will do so probably later today.

Since this was just a failed test, I imagine that there is no urgency!

Damiano Testa (Mar 13 2024 at 07:44):

I do not know why this has changed with the bump, though.

Damiano Testa (Mar 13 2024 at 07:52):

Never mind, this is a fix: it works on current master and the test passes locally on the bump: #11352.

Damiano Testa (Mar 13 2024 at 17:48):

Also, the corresponding PR to bump/v4.8.0: #11358.

Kim Morrison (Mar 13 2024 at 21:13):

@Damiano Testa, we don't actually need a separate PR to bump/v4.8.0. We just merge master into bump/v4.8.0 on a regular basis. So unless the fixes are different, you can close #11358.

Damiano Testa (Mar 13 2024 at 21:17):

Ah, thanks for the explanation! The fixes are the same, but the commenting out of the test is of course not present in the master PR, since there the test still worked/works.


Last updated: May 02 2025 at 03:31 UTC