Zulip Chat Archive

Stream: nightly-testing

Topic: adaptations for nightly-2024-08-14


Kim Morrison (Aug 15 2024 at 09:16):

#15827

Damiano Testa (Aug 15 2024 at 10:55):

These PRs to non-master branches do not get the PR summary. However, the scripts should really take two commit hashes and compute the difference based on those.

Damiano Testa (Aug 15 2024 at 10:55):

Would it be useful to think about adapting the action so that all PRs get their summary?

Damiano Testa (Aug 15 2024 at 10:56):

Oh, sorry, I did not scroll down far enough!

Damiano Testa (Aug 15 2024 at 10:56):

They may still only get the diff with master, though, not the branch on which they are getting PRed.

Johan Commelin (Aug 17 2024 at 05:49):

@Kim Morrison I've given :peace_sign:

Johan Commelin (Aug 17 2024 at 05:49):

Should we document a bit in the PR commit message why this diff is so large?

Kim Morrison (Aug 17 2024 at 06:47):

I merged bump/v4.12.0 into it; the diff is only 16 files.

Kim Morrison (Aug 17 2024 at 06:47):

and I've merged.


Last updated: May 02 2025 at 03:31 UTC